Vba code to close workbook.

[ipbr21054]

Hi,

I click OK on a Msgbox & at the same time i wish to close the workbook / save changes.

The workbook is called TAX YEAR & the worksheet is called Sheet1

I am using this line of code below BUT it only closes the worksheet Sheet1
I am trying to close the workbook that the worksheet is with in, called TAX YEAR

Can you see why it doesnt work for me.
Thanks

ActiveWorkbook.Close SaveChanges:=True

Also this didnt work either.

Workbooks("TAX YEAR").Close SaveChanges:=True

 

[Micron]

In the 2nd example, you're missing the file extension (xls, xlsx, etc.)

 

[ipbr21054]

Hi,
That didnt make any difference & did the same as in just the worksheet NOT the workbook is closed.
See before & after screen shots.
Thanks

 

[Micron]

Sorry, works for me. Maybe it has to do with your versions. 2007 is pretty old stuff
Might help others to help you if you clarify if the code is in the workbook you want to close, or if it's in another workbook. Perhaps
Application.Workbooks("Tax Year.xls").Close SaveChanges = true
That assumes it is xls, not xlsx.

Looks to me as if you're saying the application doesn't close, not the workbook. AFAIK, an open workbook must show at least one sheet. When there is no visible sheet, it looks to me as if your workbook closes but Excel remains open.

 

[ipbr21054]

The file is called Tax Year.
I open this file & have 1 worksheet of which is worksheet1.

When I run the code I want what has just be opened to close.
The file Tax Year has an extension of .xlsm

 

[NdNoviceHlp]

ipbr21054 it seems like your application is not quitting when you close your wb. My guess is that you have an addin that loads when Excel starts and your wb opens and this remains loaded after saving and closing the wb. This keeps the application running so it appears that your sheet has "closed" but what U are seeing is the addin wb. I have no idea how to close the addin (and application) without uninstalling the addin. HTH. Dave

 

[ipbr21054]

Hi,
Ive looked into what ADD Ins i have installed etc & its only the Xl2bb from this group.
I deselected it etc & ran the code again.
Its still the same so not that.

I think i will leave this as ive watched a few videos now & dont see any where the whole workbook close & only the worksheet.

Many Thanks

 

[NdNoviceHlp]

You are welcome and thanks for posting your outcome. I have a custom addin installed and was able to replicate your results. If you go to the VBE, you will see in the project explorer if there are any addins loaded. It will show more than 1 VBAProject and will indicate the name of the addin. Maybe check your task manager to see if you have more than 1 Excel process running? However, I'm not sure how this would cause your results? Beyond this, I' sorry have no further suggestions. Perhaps other will be able to help. Good luck. Dave

 

[AC PORTA VIA]

try to have

Application.Quit

after save

 

[ipbr21054]

Hi,
I have tried that but the same issue.

Thanks