VBA code to not have sheet array selected?

[jondavis1987]

Below is the end of a macro, unless it hits an error but the end of the error handler looks like this as well. This code saves two worksheets as a PDF. The problem is sometimes the users don't remember to only have it on Worksheet "A" after using this. To clarify, this worksheet is a template for reports. So they fill out the information, use the macro to copy the information into the correct workbooks, then can either hit a button deleting all of user entered information essentially resetting the worksheet or they can just type over the user entered information. If they don't make sure only Worksheet A is selected when they start typing and run the macro again some weird stuff happens. I've read you should avoid using the select method whenever possible. So what would be the appropriate way to only select sheet A at the end of this?

'   Export source workbook to PDF
    With srcWB
        fName = srcWB.Sheets("A").Range("A!F19").Value
                Sheets(Array("A", "Sheet2")).Select
    ActiveSheet.ExportAsFixedFormat Type:=xlTypePDF, Filename:= _
            "C:\Users\" & Environ("username") & "\Dropbox\Quality Control\Asphalt\Asphalt Reports\" & fName, _
        openafterpublish:=True, ignoreprintareas:=False
    End With

Exit Sub

 

[Joe4]

I've read you should avoid using the select method whenever possible. So what would be the appropriate way to only select sheet A at the end of this?

That advice usually applies to wanting to apply a bunch of actions. However, if your goal is to "select" a particular sheet, then selecting it is the way you would do that.

Note: That the main reason to usually avoid using "select" statements they are often unnecessary, and can slow your VBA performance down (especially if they are used within a loop). However, if you just want to select one particular sheet at the end of a macro, that is really going to have a neglible effect on performance (a single select is pretty insignificant).

So that is something I wouldn't really worry about.

 

[jondavis1987]

Thank you!

 

[Joe4]

You are welcome.

Where I see people get in most trouble is when they have things like this either in a loop, or have a whole bunch of statements like these in succession:

    Range("F1").Select
    ActiveCell.FormulaR1C1 = "=RC[-2]+RC[-1]"

instead of just writing this:

    Range("F1").FormulaR1C1 = "=RC[-2]+RC[-1]"