VBA my simple code not working properly

[omersinem]

Hi,
I wrote a code that which allows to delete repetitive data with the same columns and then defined a button for this but I have to click the button more than four or five times to delete the duplicate data. For example; It deletes 5 or 10 rows every time I click it. When the total data also does not decrease the number of rows, then I understand that all matching rows are deleted. I want to delete repetitive rows as stated in the attachment in one click and I want it to auto-loop through newly updated rows as rows are deleted, but I can't. Anyone who can help?
Thanks,

Sub y()

Sayfa1.Range("A2").Sort [A2], Order1:=xlDescending


For i = 2 To Sayfa1.UsedRange.Rows.Count
Sayfa1.Range("B2").Sort [B2], Order1:=xlDescending

If Sayfa1.Cells(i, 1) = Sayfa1.Cells(i + 1, 1) Then



If Sayfa1.Cells(i, 2) = Sayfa1.Cells(i + 1, 2) Then


If Sayfa1.Cells(i, 8) = "NOK" And Sayfa1.Cells(i + 1, 8) = "NOK" Then
Sayfa1.UsedRange.Rows(i + 1).Delete
ElseIf Sayfa1.Cells(i, 8) = "OK" And Sayfa1.Cells(i + 1, 8) = "OK" Then
Sayfa1.UsedRange.Rows(i + 1).Delete


End If

End If

End If
Next
End Sub

 

[I_know_nuffin]

have you tried starting from the last row and working upwards

or

when you delete a row minus one from your i count

 

[omersinem]

have you tried starting from the last row and working upwards

or

when you delete a row minus one from your i count

I have just tried first thing you said and it works properly rn.
Thank you so much

 

[Joe4]

The issue is that when you delete a row, you shift all your data upwards. So data can get missed, because you are moving an unchecked row up into the row you just checked (skipping over that row).

As a rule of thumb, if looping through rows where you may be inserting or deleting rows within the loop, it is always best to work "from the bottom up" (looping through the rows backwards, from the last to the first).