visual basic problem

[B4L4KS]

hello,

i have another problem with another worksteet, this involves customers being entered into a database and then moving down a line,

this is the code that i have

Sub adddetails()
'
' adddetails Macro
'
sourcerows = Array(8, 10, 12, 14, 16)
targetareas = Array("C", "D", "E", "F", "G")
targetrow = Sheets("Customers").Range("C" & Rows.Count).End(xlUp).Offset(1).Row
Sheets("Join Loyalty Scheme").Select
For i = LBound(sourcerows) To UBound(sourcerows)
Range("D" & sourcerows(i)).Resize(1, 1).Copy _
Destination:=Sheets("Customers").Range(targetareas(j) & targetrow)
Next
Application.CutCopyMode = False
End Sub

it doent work

anyhelp

kristian

note all the cells are correct just the visual basic is incorrect

 

[Norie]

Try adding the worksheet reference.

Something like this, assuming the source worksheet is 'Join Loyalty Sheet'.

Worksheets("Join Loyalty Sheet").Range("D" & sourcerows(I)).Resize(1, 1).Copy _
Destination:=Sheets("Customers").Range(targetareas(j) & targetrow)

 

[B4L4KS]

hi it still doesnt work here is the code and where the data is going and coming from.

code
Sub adddetails()
'
' adddetails Macro
'

sourcerows = Array(8, 10, 12, 14, 16)
targetareas = Array("C", "D", "E", "F", "G")
targetrow = Sheets("Customers").Range("C" & Rows.Count).End(xlUp).Offset(1).Row
Worksheets("Join Loyalty Sheet").Range("D" & sourcerows(i)).Resize(1, 1).Copy _
Destination:=Sheets("Customers").Range(targetareas(i) & targetrow)

Next

Application.CutCopyMode = False
End Sub

many thanks

kristian

 

[Norie]

This worked for me.

Sub adddetails()
 
    sourcerows = Array(8, 10, 12, 14, 16)
    
    targetareas = Array("C", "D", "E", "F", "G")
    
    targetrow = Sheets("Customers").Range("C" & Rows.Count).End(xlUp).Offset(1).Row
    
    For I = LBound(sourcerows) To UBound(sourcerows)
        Worksheets("Join Loyalty Sheet").Range("D" & sourcerows(I)).Copy Sheets("Customers").Range(targetareas(I) & targetrow)
    Next I
 
End Sub

You could do it like this too, which will either make things clearer or do the opposite and overcomplicate.

Option Explicit
 
Sub adddetails()
Dim wsSrc As Worksheet
Dim wsDst As Worksheet
Dim rngSrc As Range
Dim rngDst As Range
Dim targetrow As Long
Dim sourcerows
Dim targetareas
Dim I As Long
 
    sourcerows = Array(8, 10, 12, 14, 16)
 
    targetareas = Array("C", "D", "E", "F", "G")
 
    Set wsSrc = Worksheets("Join Loyalty Sheet")

    Set wsDst = Sheets("Customers")
 
    targetrow = wsDst.Range("C" & Rows.Count).End(xlUp).Offset(1).Row
 
    For I = LBound(sourcerows) To UBound(sourcerows)
        Set rngSrc = wsSrc.Range("D" & sourcerows(I))
        Set rngDst = wsDst.Range(targetareas(I) & targetrow)
        rngSrc.Copy rngDst
    Next I
 
End Sub

 

[B4L4KS]

thanks for the help it now works