Which Variable to use?

[AndrewKent]

Hi there,

On my last few threads I have been asking questions about how to best declare variables. After reading through the excellent content on C Pearsons website I now have a better understanding of how to declare a variable.

What it doesn't give me however is a list of what variables to use in certain situations. For example...

Text would be As String
Number would be As Intiger
True would be As Boolean

...does anyone have a list of what variables to use and when?

Andy

 

[RoryA]

Variants use more memory, for one thing and there is an overhead involved in coercion to the relevant type. Whether this will actually have an impact on your app, it's hard to say. More importantly, you might find the wrong types of values being allowed by your code; again, whether this will impact your app is hard to say.
More importantly I think, in the long run it will make your code easier to maintain, so you can either do it now, or you can spend more later (but as a hidden cost!) trying to track down strange errors in your program!

 

[AndrewKent]

Variants use more memory

trying to track down strange errors in your program!

Those are the two selling points right there! Thank you!

 

[RoryA]

Try and throw the phrase "lower TCO" in there. Seems to work with most IT heads...

 

[AndrewKent]

As promised, I'm back with more questions,

Message = MsgBox("Warning: Your RACF is not recognised as being part of the Financial Planning Direct department structure" & vbCrLf & vbCrLf & "Please contact the Financial Planning Direct MI Team for assistance.", Config1, "" & VersionName & "")

Would this be object?

 

[RoryA]

Nope - MsgBox returns a VbMsgBoxResult enum, which is essentially a Long integer.

 

[VoG]

I'm not sure why you would assign that to a variable. If it was

Message = MsgBox("Warning: Your RACF is not recognised as being part of the Financial Planning Direct department structure" & vbCrLf & vbCrLf & "Please contact the Financial Planning Direct MI Team for assistance.", Config1, "" & VersionName & "", vbYesNo)

I'd say VbMsgBoxResult

 

[AndrewKent]

Hi guys,

Item = WorksheetFunction.Index(Range("PolicyDataCapture_PolicySummary"), RowNo, 1)

What would item be declared as in this situation? Long?

 

[RoryA]

Variant is probably better unless you know beforehand what sort of data should be returned.

 

[AndrewKent]

Thanks that's great,

here's another...

Confirmation = Application.CountIf(Worksheets("True - False").Range("F8:F11"), "False")

 

[VoG]

Integer