why this code doesn't work at all?

[KalilMe]

hi guys
I have this code but doesn't work at all , I try updating values in some columns based on filled values in multiple textboxes

Private Sub CommandButton1_Click()
Dim sh As Worksheet
Dim sr As Range
Dim cl
Set sh = Sheets("sheet1")
c1 = Me.ComboBox1.Value
If c1 <> "" Then
 Set sr = ws.Columns(4).Find(c1, LookAt:=xlWhole)
 If Not c1 Is Nothing Then
 sh.Cells(sr.Row, "A") = Me.TextBox1.Value
 sh.Cells(sr.Row, "B") = Me.TextBox2.Value
 sh.Cells(sr.Row, "C") = Me.TextBox3.Value

 End If
End If
End Sub

can any body guide me where is the mistake ?

 

[RoryA]

I suspect this:

Set sr = ws.Columns(4).Find(c1, LookAt:=xlWhole)

should be:

Set sr = sh.Columns(4).Find(c1, LookAt:=xlWhole)

 

[KalilMe]

nothing changes .this is the code

Private Sub CommandButton2_Click()
Dim sh As Worksheet
Dim sr As Range
Dim cl
Set sh = Sheets("sheet1")
c1 = Me.ComboBox1.Value
If c1 <> "" Then
 Set sr = sh.Columns(4).Find(c1, LookAt:=xlWhole)
 If Not sr Is Nothing Then
 sh.Cells(sr.Row, "A") = Me.TextBox1.Value
 sh.Cells(sr.Row, "B") = Me.TextBox2.Value
 sh.Cells(sr.Row, "C") = Me.TextBox3.Value

 End If
End If

End Sub

 

[RoryA]

Step through the code and see what is happening. The most likely cause for no visible output would be if the Find isn't matching anything.

 

[NoSparks]

removed, sorry

 

[KalilMe]

Step through the code and see what is happening. The most likely cause for no visible output would be if the Find isn't matching anything.

if I use F8 it will run the userform I can't show the steps . what I suposse to do

 

[RoryA]

Put a breakpoint (f9) on the Set sh = ... line, then run your form, select an item in your list and press the button. You can then use f8 to step through the code and see which lines get executed.

I also suggest reading this: Debugging VBA

 

[KalilMe]

it highlights in this line

 Set sr = sh.Columns(4).Find(c1, LookAt:=xlWhole)

I would add another thing when I try updating value in textbox and press button .it clears new value and return the old value

 

[RoryA]

What is the error message? If there isn't one on that line, keep pressing f8 until you either get an error or you see what the code is missing.

There is nothing in that code to clear any other controls.

 

[KalilMe]

it doesn't show any error .it passes for all lines without any error