Code to separate two parts of a string separated by a "-"

[HarryCallaghan]

Hello.

I'm making a system to read codebar from documents and extract info from a database using this codebar. The problem is that this codebar is composed by a "serial" and a "code", both numbers separated by a bar "-". Codebars are such as "2-234", "10-543789" and strings like that. The serial number (the left partt of the string can be a number between 1 and 11 and the code part can be a number between 1 and 999999. I have this code a wrote by myself but i'm getting an error about types not matching i guess because you cant diff operate two strings , hope someone can help me:

Sub InputCodigo()
Dim Albaran As String
Albaran = "default"
Do Until Len(Albaran) = 0
Albaran = InputBox("testing etiquetas")
If Right(Left(Albaran, 2), 1) = "-" Then

Cells(2, "J").Value = Left(Albaran, 1)
Cells(2, "K").Value = Albaran - Left(Albaran, 2)


ElseIf Right(Left(Albaran, 2), 1) <> "-" Then

Cells(2, "J").Value = Left(Albaran, 2)
Cells(2, "K").Value = Albaran - Left(Albaran, 3)
End If

Loop
End Sub

 

[L. Howard]

I am vauge on what you want the end result to do or look like. If you want to seperate the codes at the "-" into two columns try this.

Option Explicit

Sub At_The_Dash()
Range("F2:F" & Range("F" & Rows.Count).End(xlUp).Row).Select

Selection.TextToColumns Destination:=Range("F2"), DataType:=xlDelimited, _
  TextQualifier:=xlDoubleQuote, ConsecutiveDelimiter:=False, Tab:=True, _
  Semicolon:=False, Comma:=False, Space:=False, Other:=True, OtherChar _
  :="-", FieldInfo:=Array(Array(1, 1), Array(2, 1)), TrailingMinusNumbers:=True
End Sub

Regards,
Howard

 

[HarryCallaghan]

Thanks a lot! I'll try your code but i figured out in other way i think even easier using the built-in function InStr. I put my code in case any of you need it:

Sub InputCodigo()
Dim Albaran As String
Dim i As Integer
Dim bar As Integer



Albaran = "default"
Do Until Len(Albaran) = 0
Albaran = InputBox("testing etiquetas")

i = Len(Albaran)
bar = InStr(Albaran, "-")
If bar > 0 Then
Cells(2, "J").Value = Left(Albaran, (bar - 1))
Cells(2, "K").Value = Right(Albaran, i - bar)
End If


Loop
End Sub