Coding Practices

[Uziel]

Hello All, in Excel I declare my variables at the top of my sheet to avoid having to recreate them over and over. Is that a bad practice for any reason?

Thank you!

Option Explicit
Option Base 1

'Application
Dim aCS As Long
'Objects
Dim oWB As Workbook
Dim oWS As Worksheet
Dim oPT As PivotTable
Dim oPI As PivotItem
Dim oPIL As PivotItemList
Dim oPIs As PivotItems
Dim oComAddin As COMAddIn
Dim oComAddins As COMAddIns
Dim oAddin As AddIn
Dim oAddins As AddIns
'Ranges
Dim rRange As range
Dim rCell As range
Dim rUR As range
Dim rRow As range
Dim rCol As range
'Long Numbers
Dim i As Long
Dim j As Long
Dim lCS As Long
Dim lCalcMode As Long
'Strings
Dim sTemp As String
'Booleans
Dim bCS As Boolean

 

[shg]

Unless those values need to persist when no code is running, it's better practice to either declare variables locally or receive them as arguments, as appropriate.

Reusing ordinary scalar variable requires that you reset them prior to usage, whereas locally declared variables are created on entry to the procedure and initialized to default values.

IMO, module-level and global variables should be used only after you're convinced your skeptical self that it's the best way for each one.