In Macros, Concatenate in cell p: c1, "_",b1,"_",d1 then save as cell p and close

[metricsboy]

 

[metricsboy]

 

[Scott Huish]

Sub test()
Range("P1") = Range("C1") & "_" & Range("B1") & "_" & Range("D1")
ThisWorkbook.Close (True)
End Sub

 

[metricsboy]

I am getting this error. I am just doing the concatenation in p1, copying and pasting value in p1, then adding your code.

 

[metricsboy]

I want to save the worksheet as p1, then close the workbook

 

[Scott Huish]

You didn't say all that in your original question. But you can't add a sub within a sub. You look like you're already doing some sort of concatenation???
Not exactly sure what you need now exactly, but you'll have to take my Sub test() and End Sub lines out for sure.

ThisWorkbook.Close(True) is the line that closes and saves the workbook.