Macro won't close fie after opening it

[simongilder]

Hi,

Please could you help with the code below, I am very new to VBA

I want to open a file whose filepath and name are determined in A1 of Sheet1. Then I want to copy the entire sheet "S1" from the newly opened workbook back to the original workbook, and paste values to a Sheet called "dump".

This seems to work fine, but I cannot get the source file to close afterwards.

Any help would be gratefully received.

Thank you.

Simon


Dim strFName As String

strFName = Sheet1.Range("A1").Value
Workbooks.Open Filename:=strFName


Worksheets("s1").Range("a1:AZ1000").Select
Selection.Copy
ThisWorkbook.Activate
ActiveWorkbook.Sheets("Dump").Activate
Range("A1").Activate
Selection.PasteSpecial Paste:=xlPasteValues, Operation:=xlNone, SkipBlanks:=False, Transpose:=False

 

[justwitt]

Have you tried

Workbooks(strFName).Close SaveChanges:=False</pre>

 

[JLGWhiz]

This will close it withous saving:

Code:
Worksbooks(strFName).Colse False
Code:

This will close and save it:

Code:
Worksbooks(strFName).Close True
Code:

 

[simongilder]

Have you tried

Workbooks(strFName).Close SaveChanges:=False

Hi, thanks for the prompt reply.

I added that to the code but the macro debugged at the last line.

Could you help?

Thanks

Simon




Dim strFName As String

strFName = Sheet1.Range("A1").Value
Workbooks.Open Filename:=strFName


Worksheets("s1").Range("a1:AZ1000").Select
Selection.Copy

ThisWorkbook.Activate

ActiveWorkbook.Sheets("Dump").Activate

Range("A1").Activate

Selection.PasteSpecial Paste:=xlPasteValues, Operation:=xlNone, SkipBlanks:=False, Transpose:=False


Workbooks(strFName).Close SaveChanges:=False

 

[JLGWhiz]

The code you are posting appears to be incomplete, and cannot be annalyzed properly as is. The pasteSpecial statement does not have a copy statement shown and if missing in the full procedure, that would cause an error message to be gererated, if this is part of a valid macro.