Please can you cand my code for an error

[ipbr21054]

Hi,
Please can you advise what ive done wrong with this line of code.
Basically the saved file is of pdf format, name is taken from cell B3 & date is taken from cell E3 but merged E3:K3


When using this line of code the file is saved as pdf & customers name all fine.

strFileName = "C:\Users\Ian\Desktop\REMOTES ETC\DISCO II CODE\DISCO II PDF\" & .Range("B3").Value & ".pdf"

However when i use this line of code which pulls the dat from cell E3 i just see an error message, unable to save.

strFileName = "C:\Users\Ian\Desktop\REMOTES ETC\DISCO II CODE\DISCO II PDF\" & .Range("B3").Value & " " & .Range("E3").Value & ".pdf"

 

[ipbr21054]

Noted & now i use thanks.
That solved that & saves ok.

Once the file is saved the next part of the code opens the pdf so i can print but this isnt now opening.

This is the code, do i need to alter it in some way ?
Saved file example TOM JONES 16-03-2023.pdf

  End With
  
  sPath = "C:\Users\Ian\Desktop\REMOTES ETC\DISCO II CODE\DISCO II PDF\"
  strFileName = sPath & Range("B3").Value & " " & Range("E3").Value & ".pdf"
  If Dir(strFileName) <> vbNullString Then
    ActiveWorkbook.FollowHyperlink strFileName
  End If

    
 
End Sub

 

[Micron]

Which is alright if the OP knows they are looking for illegal characters and knows what characters are illegal

And if they didn't know that, then they could post the output and eliminate any guessing. As I said, it's basic trouble shooting that too few people make use of.

 

[ipbr21054]

And if they didn't know that, then they could post the output and eliminate any guessing. As I said, it's basic trouble shooting that too few people make use of.

Post #4 mentions i was out at the time so couldnt do what you advised but then the next reply jogged my mind & i then had a thought

 

[Micron]

I get it. My point is that if you did the basics you probably wouldn't have had to post in the first place. If you did the basics and still didn't see the problem, then your first post should have included the output from the immediate window, thereby exposing the problem right away rather than having to post back and forth with questions and answers. Not trying to be argumentative here; just trying to help you to help yourself for next time.

 

[ipbr21054]

See screenshot & read it please

 

[MARK858]

This is the code, do i need to alter it in some way ?

The part in red needs to match the amended code in the save part

  sPath = "C:\Users\Ian\Desktop\REMOTES ETC\DISCO II CODE\DISCO II PDF\"
  strFileName = sPath & Range("B3").Value & " " & Range("E3").Value & ".pdf"

 

[ipbr21054]

Done.
I didnt remove the full stops.

This now works,may thanks.

        sPath = "C:\Users\Ian\Desktop\REMOTES ETC\DISCO II CODE\DISCO II PDF\"
        strFileName = sPath & Range("B3").Value & " " & Format(Range("E3").Value, "dd-mm-yyyy") & ".pdf"

 

[MARK858]

You're welcome