Please could you check my code

[ipbr21054]

Evening,
The code in use is shown below.

I ask for it to be checked as it doesnt seem to flow smoothly also if i move the cursor away from the MsgBox i see the cursor going around & around all the time

Private Sub Generate_Pdf_Click()
  Dim sPath As String, strFileName As String
  strFileName = "C:\Users\Ian\Desktop\REMOTES ETC\DR\DR SCREEN SHOT PDF\" & Range("G13").Value & ".pdf"
  If Dir(strFileName) <> vbNullString Then
  MsgBox "GENERATED PDF " & vbNewLine & vbNewLine & Range("G13").Value & vbNewLine & vbNewLine & "WAS NOT SAVED AS IT ALLREADY EXISTS", vbCritical + vbOKOnly, "GENERATE PDF FILE MESSAGE"
  Exit Sub
  
  End If
    With ActiveSheet
    .ExportAsFixedFormat Type:=xlTypePDF, Filename:=strFileName, Quality:=xlQualityStandard, IncludeDocProperties:=True, IgnorePrintAreas:=False
  MsgBox "PDF HAS NOW BEEN SAVED", vbInformation + vbOKOnly, "GENERATE PDF FILE MESSAGE"
  
  End With
  
  sPath = "C:\Users\Ian\Desktop\REMOTES ETC\DR\DR SCREEN SHOT PDF\"
  strFileName = sPath & Range("G13").Value & ".pdf"
  If Dir(strFileName) <> vbNullString Then
    ActiveWorkbook.FollowHyperlink strFileName
  End If
  
  InvoiceClearSheetQuestion.Show

End Sub

 

[johnnyL]

... also if i move the cursor away from the MsgBox i see the cursor going around & around all the time

That is normal behavior. It indicates that it is waiting for a response to the MsgBox.

 

[ipbr21054]

Hi,
Well I can only say that on various sheets I have many message boxes that I use & none of them do what I’ve mentioned in my first post.

Are you saying you’ve looked at my code & it’s all ok ?

Thanks.

 

[johnnyL]

Hmm, it appears I was mistaken since I can't duplicate an example. I know I have seen the behavior before many times. I guess disregard my previous post. Sorry.