VBA Do While going to 0

[BigRuski]

So I am doing a HW assingment for a class where we have to do a logic loop function seen below. I have gotten my VBA to work for every condition except for when x<50. I tried making a do while loop that will subtract 5 until x falls below 50 but instead any number that is 55 and more, it just spits out the answer 0. What am I doing wrong?

 

[Joe4]

Welcome to the Board!

It is generally advised NOT to use a lot of GOTO commands in Excel VBA. That is more "old programming methodology" that is not used much anymore. The only time I ever really use them is if I add error handling, and want to send it to my error handling code at the very bottom of my code.

Rather, it is more common to use IF...THEN...ELSE. And then you can really just follow the same flow as your workflow diagram (the "THEN" clause is the TRUE part, and the "ELSE" part is the FALSE part).
And you can nest IF...THEN...ELSE blocks inside of other IF...THEN...ELSE blocks.

So I would advise trying to rewrite your code using IF...THEN...ELSE blocks and getting rid of all the GOTOs.

 

[Joe4]

Here are a few links that show you how to nest IF statements in VBA:

VBA - Nested If Statement

VBA - Nested If Statement - An If or ElseIf statement inside another If or ElseIf statement(s). The inner If statements are executed based on the outermost If statements. This enables VBScript to handle complex conditions with ease.

www.tutorialspoint.com

VBA Multiple (Nested) If Statements - Automate Excel

In this ArticleA Single IF statementNested IFs ExplainedNested If Practical ExampleUsing ElseIfUsing a Case Statement This tutorial will show you how to use nested If statements in VBA. If statements allow you to test for a single condition in VBA to see if the condition is True or False, and...

www.automateexcel.com

 

[Joe4]

Dante,

They said it was a homework problem. I think they were just looking for tips, not someone to do it for them.
We typically maintain the policy of not doing people's homework or assignments for them.

 

[DanteAmor]

We typically maintain the policy of not doing people's homework or assignments for them.

Sorry. I usually don't answer home work, but I found it interesting to solve the diagram.
If you can delete my answer from post #4, I have no problem, instead I present a couple of tips:

BigRuski​

You must follow the sequence of the diagram.
You have in your code this:

if x < 10 and x >= 5 then msgbox "Over 5"

Actually the diagram says x >=10, so you could put:

If x >= 10 Then

---

You are declaring the function as a double, but if you are going to return a text, for example "over 5", then it must be variant.
Function ProbII_2(x As Double) As Double