VBA - What makes a procedure "too long" ?

[Dimitris254]

What makes a procedure too long? Is it the number of local variables or the sheer size of it (ie. number of code lines)?

 

[Dimitris254]

so, "procedure" refers to a sub, not a module, correct?

this makes things easier, because i can break the 2k sub to 1+3 subs (one main, calling 3 other subs)

what do you mean bu "recorded code"?

 

[MARK858]

so, "procedure" refers to a sub, not a module, correct?

Yes

what do you mean bu "recorded code"?

Recorded code is code which is created by using the macro recorder to record the actions you take which results in code that has a lot of unnecessary code.
You can usually tell if it is recorded as it normally uses a large amount of Select, Selection and Scrolling in the code.

 

[Dimitris254]

good to know, i'll try to split the 2k sub into 3-4 (it's doable, logic-wise) and see how it goes. The rest subs are below 1k lines - i assume that comments do not count for the compiler.

as for the code itself, unfortunately no, it's not recorded, so it's really hard to remove any lines =/

 

[Kyle123]

Then you need some loops