Workbook_open is not saving my workbook

[Legacy 243189]

Hello,
I came into an issue while setting up macro on a workbook i have.

the issue is i need the following sets of actions to be completed when the workbook got opened programmitcally :

save workbook
and save as pdf.

below the macro i have

Private Sub Workbook_Open()
ActiveWorkbook.Save
Basma

End Sub
Sub Basma()

ThisWorkbook.Save


ChDir "C:\NOC_Automation\Parser Reports\Count Reports"
ActiveSheet.ExportAsFixedFormat Type:=xlTypePDF, Filename:= _
"C:\NOC_Automation\Parser Reports\Count Reports\NOC Weekly Trend Reports.pdf", _
Quality:=xlQualityStandard, IncludeDocProperties:=True, IgnorePrintAreas _
:=False, OpenAfterPublish:=False


End Sub

the thing is .. when i opened the workbook and close it i got the message do you want to save changes..
this message doesn't suppose to appear cause i already saved the workbook.

Please advise where i got this macro wrong.

thanks,
Basma

 

[patel45]

why do you want save just after opening ? what sense ?

 

[Legacy 243189]

My excel sheet get updated as soon it got opened .. I need to save the new changed values.

Please advise.

 

[drgs]

Private Sub Workbook_Open()
Application.Calculate
ThisWorkbook.Save
Basma
End Sub

?
Although, I'm guessing the pdf export changes some workbook properties

 

[Legacy 243189]

Hello drgs and thank you.

I have tried the above macro which you have provided above, but this didn't solve my problem ...this open event .. seems not to save my work.

Please advise.

 

[drgs]

Private Sub Workbook_Open()
Application.Calculate
ThisWorkbook.Save
ThisWorkbook.ChangeFileAccess Mode:=xlReadOnly
Basma
End Sub

?

 

[Legacy 243189]

Thank you drgs.. that worked perfectly for the save thing.. but not the save as pdf.. please help.

 

[Legacy 243189]

[URL]http://www.excelforum.com/exce...open-is-not-saving-my-workbook.html?p=3323931[/url]

 

[drgs]

What is wrong exactly?

Private Sub Workbook_Open()
Application.Calculate
ThisWorkbook.Save
ThisWorkbook.ChangeFileAccess Mode:=xlReadOnly
Basma
ThisWorkbook.Close SaveChanges:=False
End Sub

 

[Legacy 243189]

Hello drgs and appreciated your help alot!

below the latest macro :

Private Sub Workbook_Open()
ThisWorkbook.RefreshAll
Application.Calculate
ThisWorkbook.Save
Sheets("Monthly Trend Report").Select
ChDir "C:\NOC_Automation\Parser Reports\Count Reports"
Sheets("Monthly Trend Report").ExportAsFixedFormat Type:=xlTypePDF, Filename:= _
"C:\NOC_Automation\Parser Reports\Count Reports\NOC Monthly Trend Report.pdf", _
Quality:=xlQualityStandard, IncludeDocProperties:=True, IgnorePrintAreas _
:=False, OpenAfterPublish:=False

End Sub

The issue is when i opened the excel sheet ,the macro run and now the excel is saved and got saved as PDF as well.
but when I fire the open event through batch file, the PDF which is saved by the macro , it is not the most updated.. and it seems the macro never ran when opening the file through the batch file.

it looks like an issue. with opening the excel programmatically


again thank you ..you helped me alot with the above macro.