Calling function - problem in calculation

[prinzip]

Sorry for the stupid question, but it seems the mistake is when I'm trying to call the function for the calculation. I do not do it the proper way i guess, and i get crazy results, or no results. How is the correct way for the below procedure?

Option Explicit
Dim EFCO2 As Long, CO2em As Long, x1 As Long, x2 As Long

    CO2em = Emissions(x1, x2, EFCO2)
    MsgBox "CO2 emissions = " & CO2em & " t"

Function Emissions(ENcat As Long, Ptech As Long, EFtech As Long)

    Emissions = ENcat * Ptech * EFtech * 10 ^ 6

End Function

 

[diddi]

is all of this integer math? i would consider checking that you have not overflowed or used non-integers anywhere.

 

[prinzip]

is all of this integer math? i would consider checking that you have not overflowed or used non-integers anywhere.

Changed number declaration from Long to Double, didn't change something to the result.

EFCO2 = Selection.Columns(4).Select MsgBox "CO2 em = " & CO2em & " t"

Message box says that CO2em is -1 while it had to be 71.887, at least that's the highlighten value in the excel spreadsheet.
Don't know why that

 

[diddi]

you need to step thru the code 1 line at a time and check the values as you go. there is obviously more code than you have posted. use F8 to step.

 

[Andrew Poulsom]

Crosspost:

http://www.excelforum.com/excel-pro...-calling-function-for-simple-calculation.html

Please read rule #10 here:

http://www.mrexcel.com/forum/showthread.php?t=99490

 

[diddi]

good pickup. one less to worry about.