Multiplication Table VBA

[Alcat03]

I am doing a button where when you press it, it presents two numbers between 1 and 15 and wants the user to input the answer. If the user is wrong, it tells them incorrect try again if they get it right it tells them correct. I have this code written up but an error keeps popping up. I do not know where i went wrong.


Dim num1 As Integer
Dim num2 As Integer
Dim guess As Integer
Dim product As Integer


num1 = Application.RandBetween(1, 15)
num2 = Application.RandBetween(1, 15)

product = num1 * num2
guess = InputBox("num1 * num2 =")

Do While guess <> product
If guess > product Then
InputBox ("sorry, that is incorrect. try again: [num1] * [num2]")
ElseIf guess < product Then
InputBox ("sorry, that is incorrect. try again: [num1] * [num2]")
ElseIf guess = product Then
MsgBox "Correct. num1 * num2 = product"

 

[6StringJazzer]

You are missing an End If and a Loop statement.

You are prompting the user with "num1 * num2" instead of the actual numbers.

You don't need separate tests for > and < when the action is the same for both.

You give your user no way to quit.

You are not assigning the InputBox result to guess inside the loop.


Here is a rewrite.

Sub mult()

   Dim num1 As Integer
   Dim num2 As Integer
   Dim guess As String
   Dim product As Integer
 
 
   num1 = Application.RandBetween(1, 15)
   num2 = Application.RandBetween(1, 15)
 
   product = num1 * num2
   guess = InputBox(num1 & " * " & num2 & " =")
   If guess = "" Then
      MsgBox "Time to quit"
      Exit Sub
   Else
 
      Do While guess <> product
            guess = InputBox("sorry, " & guess & " is incorrect. try again: " & num1 & " * " & num2 & " =")
            If guess = "" Then
               MsgBox "Time to quit"
               Exit Sub
            End If
      Loop
     
      MsgBox "Correct. " & num1 & " * " & num2 & " = " & product
 
   End If

End Sub

 

[Alcat03]

Thank you so much, I understand now.

 

[6StringJazzer]

Here is a cleaner version.

Sub mult()

   Dim num1 As Integer
   Dim num2 As Integer
   Dim guess As String
   Dim product As Integer
   
   
   num1 = Application.RandBetween(1, 15)
   num2 = Application.RandBetween(1, 15)
   
   product = num1 * num2
  
   guess = InputBox(num1 & " * " & num2 & " =")
   Do Until guess = product
      guess = InputBox("sorry, " & guess & " is incorrect. try again: " & num1 & " * " & num2 & " =")
      If guess = "" Then
         MsgBox "Time to quit"
         Exit Sub
      End If
   Loop
      
   MsgBox "Correct. " & num1 & " * " & num2 & " = " & product

End Sub