programming style question

[lezawang]

Hi
I have a simple UserForm. It has 2 textboxes (myname, myage) and 2 option buttons (male, female) and 1 control button (enterme) . Please see the code below.

What I want to add is to give a user a message, if the user forget to enter Name, age, and sex and hit Enter button. So I came with the following idea to fix the issue if the user did not enter name

If myname.Value = "" Then
        MsgBox "enter name"
    End If

How you would do that? is that good programming style? Thank you.

Private Sub enterme_Click()
    Dim x As Double
    x = Cells(Rows.Count, 1).End(xlUp).Row
    If myname.Value = "" Then
        MsgBox "enter name"
    End If
    Cells(x + 1, 1).Value = myname.Value
    Cells(x + 1, 2).Value = myage.Value
    If male.Value = True Then
        Cells(x + 1, 3).Value = "male"
    ElseIf female.Value = True Then
        Cells(x + 1, 3).Value = "female"
    End If
End Sub

 

[Norie]

Not sure about programming style but you probably want to add an Exit Sub to exit the Click procedure if the user hasn't entered a name.

    If myname.Value = "" Then
        MsgBox "enter name"
        Exit Sub
    End If

 

[My Aswer Is This]

If you wanted for force the user to enter and choose all the values you want
Try this:

Private Sub enterme_Click()
    'Modified  11/28/2018  6:45:19 PM  EST
    Dim x As Double
    x = Cells(Rows.Count, 1).End(xlUp).Row
    If myname.Value = "" Then MsgBox "I'm going to stop the script till you enter a name": Exit Sub
    If Myage.Value = "" Then MsgBox "I'm going to stop the script till you enter an age": Exit Sub
    If Male.Value = False And Female.Value = False Then MsgBox "I'm going to stop the script till you choose Male or Female": Exit Sub
    Cells(x + 1, 1).Value = myname.Value
    Cells(x + 1, 2).Value = Myage.Value
    If Male.Value = True Then
        Cells(x + 1, 3).Value = "male"
    ElseIf Female.Value = True Then
        Cells(x + 1, 3).Value = "female"
    End If
    Male.Value = False
    Female.Value = False
    myname.Value = ""
    Myage.Value = ""
End Sub