save as not working when I check for file type

maxx_daddy

Board Regular
Joined
Dec 3, 2010
Messages
74
Code:
        For Each objAtt In itm.Attachments        If InStr(1, objAtt.DisplayName, ".jpg") > 0 Then '<-- will save if this is gone
        stFilename = saveFolder & "\" & itm.Subject & "-" & dateFormat & ".JPG"
        i = 0
    Do While Dir(stFilename) <> ""
    i = i + 1
    stFilename = saveFolder & "\" & i & "-" & itm.Subject & "-" & dateFormat & "-" & ".jpg"
    Loop
    objAtt.SaveAsFile stFilename
        Set objAtt = Nothing
    End If  '<-- will save if this is gone
    Next

If I get rid of the If InStr and the last end if it saves all the attachments, leading me to believe I have written it wrong.
What did I do wrong? (note this code is in outlook VBA but it all works the same in my experience)
Trying to save all "jpg" files
 

Excel Facts

Quick Sum
Select a range of cells. The total appears in bottom right of Excel screen. Right-click total to add Max, Min, Count, Average.

Forum statistics

Threads
1,215,365
Messages
6,124,512
Members
449,167
Latest member
jrob72684

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top