Simplifying recorded VBA code

jaxisdex

New Member
Joined
May 26, 2015
Messages
35
Hey guys, so i had recorded some code and made my own tweaks to lessen it. i know there is a bunch more i could do to make it run faster and was hoping i could get any and all suggestions! please and thank you, it'll also help me learn how to code better if i could see more examples! each campaign has multiple offices and i break them out weekly, so this is for one such office. over all, i copy the original master sheet of info onto a new sheet, break it down to just that office, change the cache for the pivots and refresh the data that then saves itself to the file location i need it to.

Recorded code:

Private Sub CommandButton11_Click()
Sheets(Array("Snapshot", "Cancel Wheel", "Agent Cancels", _
"Agent Lost Bonus", "Owner Lost Bonus", "Trending Data", "CPS Links")).Copy

Call savePanAtlantic

ActiveSheet.PivotTables("PivotTable5").PivotSelect "'Non-Profit Name'[All]", _
xlDataAndLabel, True
ActiveSheet.PivotTables("PivotTable5").ChangePivotCache ActiveWorkbook. _
PivotCaches.Create(SourceType:=xlDatabase, SourceData:= _
"Trending Data!C1:C52", Version:=xlPivotTableVersion15)
Sheets("Cancel Wheel").Select
ActiveSheet.PivotTables("PivotTable5").ChangePivotCache ( _
"Pledge Snapshot!PivotTable5")
Sheets("Agent Cancels").Select
ActiveSheet.PivotTables("PivotTable5").ChangePivotCache ( _
"Pledge Snapshot!PivotTable5")
Sheets("Agent Lost Bonus").Select
ActiveSheet.PivotTables("PivotTable5").ChangePivotCache ( _
"Pledge Snapshot!PivotTable5")
Sheets("Owner Lost Bonus").Select
ActiveSheet.PivotTables("PivotTable5").PivotSelect "SupplierStatusReason[All]" _
, xlLabelOnly, True
ActiveSheet.PivotTables("PivotTable5").ChangePivotCache ( _
"Snapshot!PivotTable5")
Sheets("Trending Data").Select
ActiveSheet.Range("$A:$AZ").AutoFilter Field:=4, Criteria1:=Array( _
"Altavista Group Inc", "B&G Marketing Concepts", "Blue Group Inc,", "CAM Partners" _
, "FBC", "Frontier Promotions Inc", "InStile Acquisitions Inc", _
"Marketing on 6th USA", "Altavista Group 2", "Pan Atlantic - Givebridge", _
"Pan Atlantic Associates", "Polaris Communications Group Inc", _
"The Plato Group Miami", "Worldwide Concepts Inc.", "="), Operator:= _
xlFilterValues
Worksheets("Trending Data").Range("A2").Select
Worksheets("Trending Data").Range(Selection, ActiveCell.SpecialCells(xlLastCell)).Select
Selection.EntireRow.Delete
Sheets(Array("Trending Data", "CPS Links")).Select
ActiveWindow.SelectedSheets.Visible = False
Sheets("Snapshot").Select
ActiveWorkbook.RefreshAll
ActiveWorkbook.Save
End Sub

once again, thank you for the help! hopefully ill start getting better at this!
 

Excel Facts

Can Excel fill bagel flavors?
You can teach Excel a new custom list. Type the list in cells, File, Options, Advanced, Edit Custom Lists, Import, OK
You could always add this to the beginning and turn it back off at the end.

Code:
        Application.ScreenUpdating = False 'off


        Application.ScreenUpdating = True ' on

If your macro is especially heavy on the visual updates (lots of changes, charts, etc), then this might help speed up some of it.
 
Upvote 0

Forum statistics

Threads
1,215,700
Messages
6,126,279
Members
449,308
Latest member
VerifiedBleachersAttendee

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top