VBA Code: Avoid empty Rows while merging multiple files into Master file

Zatin

New Member
Joined
Mar 9, 2018
Messages
5
Hi,

I managed to customize a code got from multiple online forums that helps me merge specific sheet from multiple files stored in a folder into one master file. However, there is one critical issue that stops me from achieving the desired results.

Issue:
1. The merged data in the master file sheet has empty rows from every file. How can I only fetch rows / columns that have data in them

2. Avoidable issue:The merged data Wraps the cells, how can I not let them happen.

Please help!

The Main Code (Followed by RDM_Last Function):
Code:
Sub MergeAllWorkbooks()    Dim FirstCell As String
    Dim MyPath As String, FilesInPath As String
    Dim myFiles() As String
    Dim SourceRcount As Long, FNum As Long
    Dim mybook As Workbook, BaseWks As Worksheet
    Dim sourceRange As Range, destrange As Range
    Dim rnum As Long, CalcMode As Long


    ' Change this to the path\folder location of your files.
    MyPath = "C:\Users\zatin.dharmapuri\Desktop\3. 2018\Raw Data Month wise\Jan-2018"


    ' Add a slash at the end of the path if needed.
    If Right(MyPath, 1) <> "\" Then
        MyPath = MyPath & "\"
    End If


    ' If there are no Excel files in the folder, exit.
    FilesInPath = Dir(MyPath & "*.xl*")
    If FilesInPath = "" Then
        MsgBox "No files found"
        Exit Sub
    End If


    ' Fill the myFiles array with the list of Excel files
    ' in the search folder.
    FNum = 0
    Do While FilesInPath <> ""
        FNum = FNum + 1
        ReDim Preserve myFiles(1 To FNum)
        myFiles(FNum) = FilesInPath
        FilesInPath = Dir()
    Loop


    ' Set various application properties.
    With Application
        CalcMode = .Calculation
        .Calculation = xlCalculationManual
        .ScreenUpdating = False
        .EnableEvents = False
    End With


    ' Set the sheet name for the data to be copied to.
    Set BaseWks = ThisWorkbook.Sheets("Sheet3")
    rnum = 2


    ' Loop through all files in the myFiles array.
    If FNum > 0 Then
        For FNum = LBound(myFiles) To UBound(myFiles)
            Set mybook = Nothing
            On Error Resume Next
            Set mybook = Workbooks.Open(MyPath & myFiles(FNum))
            On Error GoTo 0


            If Not mybook Is Nothing Then
                On Error Resume Next


                'Change this range to fit your own needs.
                With mybook.Worksheets("Defect Analysis Reports")
                   Set sourceRange = .Range("A5:J104")
                End With
                
'            With mybook.Worksheets("Defect Analysis Reports")
'                FirstCell = "A5"
'                Set sourceRange = .Range(FirstCell & ":" & RDB_Last(3, .Cells))
'                'Test if the row of the last cell >= then the row of the FirstCell
'                If RDB_Last(1, .Cells) < .Range(FirstCell).Row Then
'                    Set sourceRange = Nothing
'                End If
'            End With
                    
                If Err.Number > 0 Then
                    Err.Clear
                    Set sourceRange = Nothing
                Else
                    ' If source range uses all columns then
                    ' skip this file.
                    If sourceRange.Columns.Count >= BaseWks.Columns.Count Then
                        Set sourceRange = Nothing
                    End If
                End If
                On Error GoTo 0


                If Not sourceRange Is Nothing Then


                    SourceRcount = sourceRange.Rows.Count


                    If rnum + SourceRcount >= BaseWks.Rows.Count Then
                        MsgBox "There are not enough rows in the target worksheet."
                        BaseWks.Columns.AutoFit
                        mybook.Close savechanges:=False
                        GoTo ExitTheSub
                    Else


                        ' Copy the file name in column A.
                        With sourceRange
                            BaseWks.Cells(rnum, "A"). _
                                    Resize(.Rows.Count).Value = myFiles(FNum)
                        End With


                        ' Set the destination range.
                        Set destrange = BaseWks.Range("B" & rnum)


                        ' Copy the values from the source range
                        ' to the destination range.
                        With sourceRange
                            Set destrange = destrange. _
                                            Resize(.Rows.Count, .Columns.Count)
                        End With
                        destrange.Value = sourceRange.Value


                        rnum = rnum + SourceRcount
                    End If
                End If
                mybook.Close savechanges:=False
            End If


        Next FNum
'        BaseWks.Columns.AutoFit
    End If


ExitTheSub:
    ' Restore the application properties.
    With Application
        .ScreenUpdating = True
        .EnableEvents = True
        .Calculation = CalcMode
    End With
    
    MsgBox "All Data has been merged successfully"
    
End Sub

I use RDM_Last Function that is saved in a different Module. It is to avoid the very issue I have but does not work. Below is the code

Code:
Function RDB_Last(choice As Integer, rng As Range)' A choice of 1 = last row.
' A choice of 2 = last column.
' A choice of 3 = last cell.
   Dim lrw As Long
   Dim lcol As Integer


   Select Case choice


   Case 1:
      On Error Resume Next
      RDB_Last = rng.Find(what:="*", _
                          After:=rng.Cells(1), _
                          Lookat:=xlPart, _
                          LookIn:=xlFormulas, _
                          SearchOrder:=xlByRows, _
                          SearchDirection:=xlPrevious, _
                          MatchCase:=False).Row
      On Error GoTo 0


   Case 2:
      On Error Resume Next
      RDB_Last = rng.Find(what:="*", _
                          After:=rng.Cells(1), _
                          Lookat:=xlPart, _
                          LookIn:=xlFormulas, _
                          SearchOrder:=xlByColumns, _
                          SearchDirection:=xlPrevious, _
                          MatchCase:=False).Column
      On Error GoTo 0


   Case 3:
      On Error Resume Next
      lrw = rng.Find(what:="*", _
                    After:=rng.Cells(1), _
                    Lookat:=xlPart, _
                    LookIn:=xlFormulas, _
                    SearchOrder:=xlByRows, _
                    SearchDirection:=xlPrevious, _
                    MatchCase:=False).Row
      On Error GoTo 0


      On Error Resume Next
      lcol = rng.Find(what:="*", _
                     After:=rng.Cells(1), _
                     Lookat:=xlPart, _
                     LookIn:=xlFormulas, _
                     SearchOrder:=xlByColumns, _
                     SearchDirection:=xlPrevious, _
                     MatchCase:=False).Column
      On Error GoTo 0


      On Error Resume Next
      RDB_Last = rng.Parent.Cells(lrw, lcol).Address(False, False)
      If Err.Number > 0 Then
         RDB_Last = rng.Cells(1).Address(False, False)
         Err.Clear
      End If
      On Error GoTo 0


   End Select
End Function
 

Excel Facts

Formula for Yesterday
Name Manager, New Name. Yesterday =TODAY()-1. OK. Then, use =YESTERDAY in any cell. Tomorrow could be =TODAY()+1.

Forum statistics

Threads
1,215,335
Messages
6,124,327
Members
449,155
Latest member
ravioli44

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top