VBA Script: Clear Source Sheets Formatting before Merging Data

Zatin

New Member
Joined
Mar 9, 2018
Messages
5
Hi,
I have a code that successfully merges data from a specific named sheets of multiple workbooks into specific master workbook sheet.


However, the code merges empty rows too that have some sort of formatting in them. In my case, the source sheets have borderlines without any values in the rows. I tried using
Code:
SourceRange.Range(FirstCell & ":" & RDB_Last(3, .Cells)).ClearFormats
but it fails to resolve the problem. Also, I noticed that the code fetches 527 rows of data from every sheet file with the exception of the 1st file in the folder. As I had manually cleared formatting from it for testing purposes.


If I manually clear the formatting from the source files, save the file and then run the code it works right. But that's not possible in real time scenario.


A novice to VBA. Please help. Thanks in Advance.


Note: Please change MyPath in the code. Attachment option is not working for me to provide the files. So I have shared the Zip Folder on my G Drive.


Folder URL: https://drive.google.com/file/d/11XE...ew?usp=sharing


The Code:

Code:
Sub MergeAllWorkbooks2()
Dim FirstCell As String
Dim MyPath As String, FilesInPath As String
Dim myFiles() As String
Dim SourceRcount As Long, FNum As Long
Dim mybook As Workbook, BaseWks As Worksheet
Dim sourceRange As Range, destrange As Range
Dim rnum As Long, CalcMode As Long


' Change this to the path\folder location of your files.
MyPath = "C:\Users\zatin.dharmapuri\Desktop\3. 2018\Raw Data Month wise\Jan-2018"


' Add a slash at the end of the path if needed.
If Right(MyPath, 1) <> "\" Then
    MyPath = MyPath & "\"
End If


' If there are no Excel files in the folder, exit.
FilesInPath = Dir(MyPath & "*.xl*")
If FilesInPath = "" Then
    MsgBox "No files found"
    Exit Sub
End If


' Fill the myFiles array with the list of Excel files
' in the search folder.
FNum = 0
Do While FilesInPath <> ""
    FNum = FNum + 1
    ReDim Preserve myFiles(1 To FNum)
    myFiles(FNum) = FilesInPath
    FilesInPath = Dir()
Loop


' Set various application properties.
With Application
    CalcMode = .Calculation
    .Calculation = xlCalculationManual
    .ScreenUpdating = False
    .EnableEvents = False
End With


' The sheet name for the data to be copied to.
Set BaseWks = ThisWorkbook.Sheets("Sheet3")
rnum = 2


' Loop through all files in the myFiles array.
If FNum > 0 Then
    For FNum = LBound(myFiles) To UBound(myFiles)
        Set mybook = Nothing
        On Error Resume Next
        Set mybook = Workbooks.Open(MyPath & myFiles(FNum))
        On Error GoTo 0


        If Not mybook Is Nothing Then
            On Error Resume Next


            'Change this range to fit your own needs.
            'With mybook.Worksheets("Defect Analysis Reports")
               'Set sourceRange = .Range("A5:J104")
            'End With


        With mybook.Worksheets("Defect Analysis Reports")
            FirstCell = "A5"
            Set sourceRange = .Range(FirstCell & ":" & RDB_Last(3, .Cells))
            .Range(FirstCell & ":" & RDB_Last(3, .Cells)).ClearFormats
            'Test if the row of the last cell >= then the row of the FirstCell
            If RDB_Last(1, .Cells) < .Range(FirstCell).Row Then
                Set sourceRange = Nothing


            End If
        End With


            If Err.Number > 0 Then
                Err.Clear
                Set sourceRange = Nothing
            Else
                ' If source range uses all columns then
                ' skip this file.
                If sourceRange.Columns.Count >= BaseWks.Columns.Count Then
                    Set sourceRange = Nothing
                End If
            End If
            On Error GoTo 0


            If Not sourceRange Is Nothing Then


                SourceRcount = sourceRange.Rows.Count


                If rnum + SourceRcount >= BaseWks.Rows.Count Then
                    MsgBox "There are not enough rows in the target worksheet."
                    BaseWks.Columns.AutoFit
                    mybook.Close savechanges:=False
                    GoTo ExitTheSub
                Else


                    ' Copy the file name in column A.
                    With sourceRange
                        BaseWks.Cells(rnum, "A"). _
                                Resize(.Rows.Count).Value = myFiles(FNum)
                    End With


                    ' Set the destination range.
                    Set destrange = BaseWks.Range("B" & rnum)


                    ' Copy the values from the source range
                    ' to the destination range.
                    With sourceRange
                    Set destrange = destrange. _
                                        Resize(.Rows.Count, .Columns.Count)
                    End With
                    destrange.Value = sourceRange.Value


                    rnum = rnum + SourceRcount
                End If
            End If
            mybook.Close savechanges:=False
        End If


    Next FNum
    'BaseWks.Columns.AutoFit
End If
       ExitTheSub:
       'Restore the application properties.
     With Application
    .ScreenUpdating = True
    .EnableEvents = True
    .Calculation = CalcMode
End With


MsgBox "All Data has been merged successfully"
End Sub
 

Excel Facts

How to change case of text in Excel?
Use =UPPER() for upper case, =LOWER() for lower case, and =PROPER() for proper case. PROPER won't capitalize second c in Mccartney
Please Note: RDM_Last function is used to determine the last row/cell with value. This code can be found from the bottom most section of the following URL: https://www.rondebruin.nl/win/s3/win008.htm

Code:
Function RDB_Last(choice As Integer, rng As Range)
'Ron de Bruin, 5 May 2008
' 1 = last row
' 2 = last column
' 3 = last cell
    Dim lrw As Long
    Dim lcol As Integer


    Select Case choice


    Case 1:
        On Error Resume Next
        RDB_Last = rng.Find(What:="*", _
                            after:=rng.Cells(1), _
                            Lookat:=xlPart, _
                            LookIn:=xlFormulas, _
                            SearchOrder:=xlByRows, _
                            SearchDirection:=xlPrevious, _
                            MatchCase:=False).Row
        On Error GoTo 0


    Case 2:
        On Error Resume Next
        RDB_Last = rng.Find(What:="*", _
                            after:=rng.Cells(1), _
                            Lookat:=xlPart, _
                            LookIn:=xlFormulas, _
                            SearchOrder:=xlByColumns, _
                            SearchDirection:=xlPrevious, _
                            MatchCase:=False).Column
        On Error GoTo 0


    Case 3:
        On Error Resume Next
        lrw = rng.Find(What:="*", _
                       after:=rng.Cells(1), _
                       Lookat:=xlPart, _
                       LookIn:=xlFormulas, _
                       SearchOrder:=xlByRows, _
                       SearchDirection:=xlPrevious, _
                       MatchCase:=False).Row
        On Error GoTo 0


        On Error Resume Next
        lcol = rng.Find(What:="*", _
                        after:=rng.Cells(1), _
                        Lookat:=xlPart, _
                        LookIn:=xlFormulas, _
                        SearchOrder:=xlByColumns, _
                        SearchDirection:=xlPrevious, _
                        MatchCase:=False).Column
        On Error GoTo 0


        On Error Resume Next
        RDB_Last = rng.Parent.Cells(lrw, lcol).Address(False, False)
        If Err.Number > 0 Then
            RDB_Last = rng.Cells(1).Address(False, False)
            Err.Clear
        End If
        On Error GoTo 0


    End Select
End Function
 
Upvote 0
Cross posted https://www.excelforum.com/excel-pr...ce-sheets-formatting-before-merging-data.html

Cross-Posting
While we do not prohibit Cross-Posting on this site, we do ask that you please mention you are doing so and provide links in each of the threads pointing to the other thread (see rule 13 here along with the explanation: Forum Rules).
This way, other members can see what has already been done in regards to a question, and do not waste time working on a question that may already be answered.
 
Upvote 0

Forum statistics

Threads
1,215,009
Messages
6,122,674
Members
449,091
Latest member
peppernaut

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top