Add to external Excel database

COwen

Board Regular
Joined
Feb 27, 2020
Messages
225
Office Version
  1. 365
  2. 2019
  3. 2016
Platform
  1. Windows
I am trying to add to add date from a Userform on one workbook to another workbook that holds my data. Here is the code I have currently:

VBA Code:
Private Sub imgGenerate_Click()
Dim wb As Workbook
Dim ws As Worksheet
Dim x As Integer
With Sheet12 'Worksheets("Sample Router")
    .Range("INV").Value = cntrl5.Value
    .Range("SON").Value = cntrl6.Value
    .Range("Cust").Value = cntrl8.Value
    .Range("IDate").Value = cntrl7.Value
    .Range("EDate").Value = cntrl4.Value
    .Range("RouterX").Value = (.Range("RouterX").Value + 1)
    '.Range("A1:O62").PrintOut
End With
On Error GoTo Err
Application.ScreenUpdating = False

    With Application
        .DisplayAlerts = False
        .Visible = False
        .ScreenUpdating = False
    End With
    
    Set wb = Workbooks.Open(Filename:="C:\Users\caleb.owen\Documents\Cordial FileTracker tobezip\XLDataBaseforCordial.xlsm")
    Set ws = wb.Worksheets("Sheet1")
    
    'find first empty row in database
    'iRow = ws.Cells(Rows.Count, 1).End(xlUp).Offset(1, 0).Row
    iRow = ws.Cells(Rows.Count, 1).End(xlUp).Offset(1, 0).Row
    'copy the data to the database
    ws.Cells(iRow, 0).Value = Me.cntrl1.Value
    ws.Cells(iRow, 2).Value = Me.cntrl2.Value
    ws.Cells(iRow, 3).Value = Me.cntrl5.Value
    ws.Cells(iRow, 4).Value = Me.cntrl6.Value
    ws.Cells(iRow, 5).Value = Me.cntrl7.Value
    ws.Cells(iRow, 6).Value = Me.cntrl8.Value
    ws.Cells(iRow, 7).Value = Me.cntrl4.Value
    ws.Cells(iRow, 8).Value = Me.cntrl9.Value
    ws.Cells(iRow, 9).Value = Me.cntrl3.Value
    ws.Cells(iRow, 10).Value = Me.cntrl10.Value
Err:
    Workbooks("XLDataBaseforCordial.xlsm").Close True
    
With Sheet12 'Worksheets("Sample Router")
    .Range("INV").Value = ""
    .Range("SON").Value = ""
    .Range("Cust").Value = ""
    .Range("IDate").Value = ""
    .Range("EDate").Value = ""
End With
cntrl2.Value = Sheet12.Range("RouterV").Value
For x = 5 To 10
Me.Controls("cntrl" & x).Value = ""
Next x
End Sub

It is not populating correctly at all. It will only add the data to the first line then it will stop.
 
Glad it's working & thanks for the feedback.
Unfortunately typo's are easy to make & we've all been there
 
Upvote 0

Excel Facts

How to find 2nd largest value in a column?
MAX finds the largest value. =LARGE(A:A,2) will find the second largest. =SMALL(A:A,3) will find the third smallest
Well, easy or not to make, I poured over that code for hours and did not catch the error.
 
Upvote 0

Forum statistics

Threads
1,215,036
Messages
6,122,794
Members
449,095
Latest member
m_smith_solihull

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top