Assistance needed in amending a macro.

ghrek

Board Regular
Joined
Jul 29, 2005
Messages
99
Hi

I had this macro that compared data between sheets 1 and 2 and marked "OK" "MISSING" and "DUPLICATE"

What im trying to amend it to do is to mark "OK" and "DUPLICATE" on sheet 1 still but when data is on sheet 2 but not on sheet 1 I need it marked "MISSING" on the row concerned on sheet 2.

Any ideas on how I can do this?


Sub compare_data()
Dim sh1 As Worksheet, sh2 As Worksheet
Dim i As Long, j As Long, lr As Long

Set sh1 = ActiveWorkbook.Sheets("Sheet1")
Set sh2 = ActiveWorkbook.Sheets("Sheet2")

Application.ScreenUpdating = False
lr = sh1.Range("A" & sh1.Rows.Count).End(xlUp).Row
For i = 2 To lr
Application.StatusBar = "Checking row : " & i & " of : " & lr
j = Application.CountIfs(sh2.Columns("A"), sh1.Cells(i, "A").Value, sh2.Columns("B"), sh1.Cells(i, "B").Value, sh2.Columns("C"), sh1.Cells(i, "C").Value, _
sh2.Columns("D"), sh1.Cells(i, "D").Value)
Select Case j
Case 0
sh1.Cells(i, "E").Value = "MISSING"
Case 1
sh1.Cells(i, "E").Value = "OK"
Case Is > 1
sh1.Cells(i, "E").Value = "DUPLICATE"
End Select
Next
MsgBox "Done"
End Sub

Thanks
 

DanteAmor

Well-known Member
Joined
Dec 3, 2018
Messages
8,900
Office Version
2007
Platform
Windows
Now you need to look for each data of sheet2 on sheet1.

Try this:

Code:
Sub compare_data()
  Dim sh1 As Worksheet, sh2 As Worksheet
  Dim i As Long, j As Long, lr As Long
  
  Set sh1 = ActiveWorkbook.Sheets("Sheet1")
  Set sh2 = ActiveWorkbook.Sheets("Sheet2")
  
  Application.ScreenUpdating = False
  Application.StatusBar = False
  lr = sh1.Range("A" & sh1.Rows.Count).End(xlUp).Row
  'Search 1 in 2
  For i = 2 To lr
    Application.StatusBar = "Checking row : " & i & " of : " & lr
    j = Application.CountIfs(sh2.Columns("A"), sh1.Cells(i, "A").Value, sh2.Columns("B"), sh1.Cells(i, "B").Value, sh2.Columns("C"), sh1.Cells(i, "C").Value, _
    sh2.Columns("D"), sh1.Cells(i, "D").Value)
    Select Case j
      Case 0
      sh1.Cells(i, "E").Value = "MISSING"
      Case 1
      sh1.Cells(i, "E").Value = "OK"
      Case Is > 1
      sh1.Cells(i, "E").Value = "DUPLICATE"
    End Select
  Next
  '
[COLOR=#008000]  'Search 2 in 1[/COLOR]
[COLOR=#0000ff]  lr = sh2.Range("A" & sh1.Rows.Count).End(xlUp).Row[/COLOR]
[COLOR=#0000ff]  For i = 2 To lr[/COLOR]
[COLOR=#0000ff]    Application.StatusBar = "Checking row : " & i & " of : " & lr[/COLOR]
[COLOR=#0000ff]    j = Application.CountIfs(sh1.Columns("A"), sh2.Cells(i, "A").Value, sh1.Columns("B"), sh2.Cells(i, "B").Value, _[/COLOR]
[COLOR=#0000ff]      sh1.Columns("C"), sh2.Cells(i, "C").Value, sh1.Columns("D"), sh2.Cells(i, "D").Value)[/COLOR]
[COLOR=#0000ff]    Select Case j[/COLOR]
[COLOR=#0000ff]      Case 0[/COLOR]
[COLOR=#0000ff]      sh2.Cells(i, "E").Value = "MISSING"[/COLOR]
[COLOR=#0000ff]    End Select[/COLOR]
[COLOR=#0000ff]  Next[/COLOR]
  MsgBox "Done"
End Sub
 

DanteAmor

Well-known Member
Joined
Dec 3, 2018
Messages
8,900
Office Version
2007
Platform
Windows
I'm glad to help you. Thanks for the feedback.
 

Forum statistics

Threads
1,082,371
Messages
5,365,055
Members
400,819
Latest member
Gossow

Some videos you may like

This Week's Hot Topics

  • populate from drop list with multiple tables
    Hi All, i have a drop list that displays data, what i want is when i select one of those from the list to populate text from different tables on...
  • Find list of words from sheet2 in sheet1 before a comma and extract text vba
    Hi Friends, Trying to find the solution on my task. But did not find suitable one to the need. Here is my query and sample file with details...
  • Dynamic Formula entry - VBA code sought
    Hello, really hope one of you experts can help with this - i've spent hours on this and getting no-where. .I have a set of data (more rows than...
  • Listbox Header
    Have a named range called "AccidentsHeader" Within my code I have: [CODE]Private Sub CommandButton1_Click() ListBox1.RowSource =...
  • Complex Heat Map using conditional formatting
    Good day excel world. I have a concern. Below link have a list of countries that carries each country unique data. [URL...
  • Conditional formatting
    Hi good morning, hope you can help me please, I have cells P4:P54 and if this cell is equal to 1 then i want row O to say "Fully Utilised" and to...
Top