Macro Efficiency

dturgel

Board Regular
Joined
Aug 6, 2015
Messages
58
Hi,

I saw in JWalk's 2013PPw/VBA the following macro:

Code:
Sub Macro5()
ActiveCell.Resize(,6)=Array("Jan","Feb","Mar","Apr","May","Jun")
End Sub

I then wanted to reduce the following code in similar fashion:

Code:
Sub AuthorizedShare()
        With ActiveWorkbook.Worksheets("Summary Quoted")        
        .Range("T103").Formula = "=MCTSI2QuotedShareL1"
        .Range("T104").Formula = "=MCTSI2QuotedShareL2"
        .Range("T105").Formula = "=MCTSI2QuotedShareL3"
        .Range("T106").Formula = "=MCTSI2QuotedShareL4"
        .Range("T107").Formula = "=MCTSI2QuotedShareL5"
        .Range("T117").Formula = "=MCTSI2QuotedShareL1"
        .Range("T118").Formula = "=MCTSI2QuotedShareL2"
        .Range("T119").Formula = "=MCTSI2QuotedShareL3"
        .Range("T120").Formula = "=MCTSI2QuotedShareL4"
        .Range("T121").Formula = "=MCTSI2QuotedShareL5"
        End With
End Sub

So I tried this:

Code:
Sub AuthorizedShare()
   With ActiveWorkbook.Worksheets("Summary Quoted")
     .Range("T103:T107").Formula = Array("=MCTSI2QuotedShareL1", "=MCTSI2QuotedShareL2", "=MCTSI2QuotedShareL3", "=MCTSI2QuotedShareL4", "=MCTSI2QuotedShareL5")
    End With
End Sub

Problem is in each cell T103:T107 I got "=MCTSI2QuotedShareL1" instead of the five separate ones I wanted. Any idea how I can change the Array formula coding to get it right?

Thanks!

Daniel
 

Excel Facts

How to find 2nd largest value in a column?
MAX finds the largest value. =LARGE(A:A,2) will find the second largest. =SMALL(A:A,3) will find the third smallest
Hi Daniel, The array needs to be transposed if it is to entered as a single column in the worksheet instead of a single row.

To modify JWalk's example it would look like...
Code:
ActiveCell.Resize(6) = Application.Transpose(Array("Jan", "Feb", "Mar", "Apr", "May", "Jun"))
 
Upvote 0
Just a quick question.
Are the L1, L2, L3 etc Cell addresses?
If so, I think you need an exclamation mark (!) before the Cell Addresses like "=MCTSI2QuotedShare!L1"
 
Upvote 0
Just for the heck of it.
Code:
Sub Maybe()
    Dim adrArr, shareArr, j As Long
    adrArr = Array("T103", "T104", "T105", "T106", "T107", "T117", "T118", "T119", "T120", "T121")
    shareArr = Array(1, 2, 3, 4, 5, 1, 2, 3, 4, 5)
    For j = LBound(adrArr) To UBound(adrArr)
        Range(adrArr(j)).Formula = "=MCTSI2QuotedShare!L" & shareArr(j)
    Next j
End Sub
 
Upvote 0
Jerry, many thanks! I combined your formula with mine to get the following which worked:

Code:
.Range("T103:T107").Formula = Application.Transpose(Array("=MCTSI2QuotedShareL1", "=MCTSI2QuotedShareL2", "=MCTSI2QuotedShareL3", "=MCTSI2QuotedShareL4", "=MCTSI2QuotedShareL5"))

Really appreciate it!

Daniel
 
Upvote 0

Forum statistics

Threads
1,215,943
Messages
6,127,814
Members
449,409
Latest member
katiecolorado

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top