VBA error 91 creating elbow connector

[Johnny C]

Hi

I've got a weird problem. I've got code to connect 2 shapes with an elbow connector using a function with start and end shape as parameters.

    Dim conlink as Shape
...other code
    conLink = AddElbowConnector(shpSourceSheetShape, shpTargetSheetShape)

Both shapes exist and the first time it connects them it works ok. The second time it tries to add a connector (it doesn't matter if there's multiple connectors connecting the 2 shapes) it crashes with this error and highlights the line above:

Run time error 91: Object variable or With block variable not set.

When I debug however and press F8 it steps into the function and the function works fine, it's the assignation of the shape the function returns that causes the problem.

I can get around it with an On Error Resume Next but I want to know why it's crashing.

 

[BiocideJ]

I don't see any documentation on this function (AddElbowConnector) so I can only assume it is a function you created.
I can make some assumptions, but if none of this helps, you will need to post at least the first line of the function (with the arguments and returns).

My theories:
I suspect that the function is returning an object and thus you need to use set when assigning the variable.
Actually, since conLink is a Shape, it either HAS to return an object or else it isn't returning a shape at all.
My solution:

Set conLink = AddElbowConnector(shpSourceSheetShape, shpTargetSheetShape)

 

[Johnny C]

It may be that I need a set.
But it works the first time, it's the second time it crashes. Or it may be more, it adds a connection each time a condition for the second box is true. So maybe there's a maximum number of times you can add an elbow between 2 boxes.

Shapes are weird, you can have as many shapes as you want in a sheet with the same name, you can have a name as null but you can't connect a connector from a shape with a null name