Vba if, elseif

[bsquad]

Looking to see why this isn't working,
both x and y are Integers

I am really hoping this is simple, but I have this segment with nested in my code and when doing it step by step or F8 and when I run it normally its not working. Like if x = 8, it specifies y = 7 which is totally not right; and insight would be helpful - maybe I have the logic wrong I am not sure

I have a For x = 1 to worksheets.count thing going on above the code below

                            If x = 1 Then
                            y = 15
                                ElseIf x = 2 Then
                                y = 8
                                ElseIf x = 3 Or 4 Or 9 Then
                                y = 7
                                ElseIf x = 5 Or 7 Or 8 Or 10 Then
                                y = 3
                                ElseIf x = 8 Then
                                y = 12
                            End If

 

[Joe4]

You cannot do ORs like this:

ElseIf x = 3 Or 4 Or 9 Then

They need to be spelled out like this

ElseIf x = 3 Or x = 4 Or x = 9 Then

I would prefer to use Case statements, though:

    Select Case x
        Case 1
            y = 15
        Case 2
            y = 8
        Case 3, 4, 9
            y = 7
        Case 5, 7, 8, 10
            y = 3
        Case Else
            y = 12
    End Select

Also note that you have x=8 listed twice (in your last two checks). You will want to fix that.

 

[bsquad]

Thank you!, I knew it was something stupid I missed.